Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mimir dashboards #8

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Add Mimir dashboards #8

merged 1 commit into from
Jul 28, 2023

Conversation

MichelHollands
Copy link
Contributor

@MichelHollands MichelHollands commented Jul 27, 2023 •
edited
Loading

This PR adds the dashboards from https://github.com/grafana/mimir/tree/main/operations/mimir-mixin-compiled/dashboards. These take up the vast majority of the PR. They are provisioned as well.

Tested by installing the helm chart and checking the dashboards are there.

@MichelHollands
Add Mimir dashboards
db493fb 
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
@MichelHollands MichelHollands requested review from trevorwhitney and a team July 27, 2023 14:42
trevorwhitney
trevorwhitney approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, good addition, but I'd love to see a jsonnet job in the future that actually compiles these at helm install time.

@MichelHollands MichelHollands merged commit 6ce4be7 into main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevorwhitney trevorwhitney trevorwhitney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichelHollands @trevorwhitney